Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unuse and not needed functions in FileCrawler interface #4788

Merged
merged 4 commits into from
Aug 13, 2024
Merged

remove unuse and not needed functions in FileCrawler interface #4788

merged 4 commits into from
Aug 13, 2024

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Aug 13, 2024 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • Not being used
  • Need to re-write and maybe use more JB native API as these stale implementation may have performance concern due to repetitive runReadAction and IO

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner August 13, 2024 03:22
@Will-ShaoHua Will-ShaoHua changed the title remove unuse and not needed functions remove unuse and not needed functions in FileCrawler interface Aug 13, 2024
@Will-ShaoHua Will-ShaoHua requested a review from andrewyuq August 13, 2024 03:26
@Will-ShaoHua Will-ShaoHua mentioned this pull request Aug 13, 2024
Closed
6 tasks
rli
rli reviewed Aug 13, 2024
View reviewed changes
...tware/aws/toolkits/jetbrains/services/codewhisperer/util/CodeWhispererFileContextProvider.kt Outdated
Comment on lines 139 to 140
var logStr = "Successfully fetched supplemental context."
it.contents.forEachIndexed { index, chunk ->
Copy link
Contributor

@rli rli Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

val logStr = buildString {
    forEachIndexed {
        append(...)
    }
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

donedone

@Will-ShaoHua Will-ShaoHua requested a review from rli August 13, 2024 19:03
@Will-ShaoHua Will-ShaoHua merged commit 26c7f16 into aws:main Aug 13, 2024
11 of 12 checks passed
@Will-ShaoHua Will-ShaoHua deleted the cwspr-crossfile-cleanup branch August 13, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rli rli rli approved these changes

@andrewyuq andrewyuq andrewyuq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Will-ShaoHua @rli @andrewyuq